👋 Welcome back myankelevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@myankelev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8360562: sun/security/tools/keytool/i18n.java add an ability to add comment for failures

Reviewed-by: rhalade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1265 new commits pushed to the master branch:

• 3d113af: 8369051: More small Float16 refactorings
• 5fccabf: 8368670: Deadlock in JFR on event register + class load
• 1a03a1f: 8369033: Remove dead code in training data
• ... and 1262 more: https://git.openjdk.org/jdk/compare/aa1911191cf8c2b855268a76baf0757909d66d1b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@myankelev The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@myankelev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

Webrevs

• 01: Full - Incremental (9f8f1a48)
• 00: Full (ac4349b4)

@myankelev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@myankelev This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

/open

@myankelev This pull request is now open

/open

@myankelev This pull request is already open

Is this enhancement requested related to some test failure that were not clear to triage? The fix looks good but is there a need for it?

Is this enhancement requested related to some test failure that were not clear to triage? The fix looks good but is there a need for it?

Yes, the error was missed several times before, as there was no comment. The error itself turned out to be a non-issue, but it was still missed and triaging it took quite a bit of time.

This particular issue was documented here JDK-8360400. After evaluation the decision was made to remove the test case after JDK-8360416.

/integrate

Going to push as commit ebb6fd7.
Since your change was applied there have been 1272 commits pushed to the master branch:

• 3790965: 8336695: Update Commons BCEL to Version 6.10.0
• f62b9ec: 8364929: Assign unique id to each AdapterBlob stored in AOTCodeCache
• 854b384: 8304811: vmTestbase/vm/mlvm/indy/func/jvmti/stepBreakPopReturn/INDIFY_Test.java fails with JVMTI_ERROR_TYPE_MISMATCH
• ... and 1269 more: https://git.openjdk.org/jdk/compare/aa1911191cf8c2b855268a76baf0757909d66d1b...master

Your commit was automatically rebased without conflicts.

@myankelev Pushed as commit ebb6fd7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.